- 
                Notifications
    You must be signed in to change notification settings 
- Fork 13.9k
Suggest Replacing Comma with Semicolon in Incorrect Repeat Expressions #128110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| rustbot has assigned @petrochenkov. Use  | 
21132fb    to
    88be2cb      
    Compare
  
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
88be2cb    to
    14c4da1      
    Compare
  
    | r? compiler | 
| ☔ The latest upstream changes (presumably #125443) made this pull request unmergeable. Please resolve the merge conflicts. | 
14c4da1    to
    d45665c      
    Compare
  
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
d45665c    to
    8550f05      
    Compare
  
    | @fmease friendly bump | 
| r? compiler | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, let me post what I had pending
| ☔ The latest upstream changes (presumably #131724) made this pull request unmergeable. Please resolve the merge conflicts. | 
8550f05    to
    6404280      
    Compare
  
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
6404280    to
    7042268      
    Compare
  
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
7042268    to
    e4d32b6      
    Compare
  
    
      
        
              This comment has been minimized.
        
        
      
    
  This comment has been minimized.
e4d32b6    to
    d982563      
    Compare
  
    d982563    to
    4c43ae6      
    Compare
  
    4c43ae6    to
    98cc345      
    Compare
  
    | Thanks for your patience. | 
…gillot Suggest Replacing Comma with Semicolon in Incorrect Repeat Expressions Fixes rust-lang#80173 This PR detects typos in repeat expressions like `["_", 10]` and `vec![String::new(), 10]` and suggests replacing comma with semicolon. Also, improves code in other place by adding doc comments and making use of a helper function to check if a type implements `Clone`. References: 1. For `vec![T; N]`: https://doc.rust-lang.org/std/macro.vec.html 2. For `[T; N]`: https://doc.rust-lang.org/std/primitive.array.html
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#128110 (Suggest Replacing Comma with Semicolon in Incorrect Repeat Expressions) - rust-lang#134609 (Add new `{x86_64,i686}-win7-windows-gnu` targets) - rust-lang#134875 (Implement `const Destruct` in old solver) - rust-lang#135221 (Include rustc and rustdoc book in replace-version-placeholder) - rust-lang#135231 (bootstrap: Add more comments to some of the test steps) - rust-lang#135256 (Move `mod cargo` below the import statements) Failed merges: - rust-lang#135195 (Make `lit_to_mir_constant` and `lit_to_const` infallible) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#128110 - veera-sivarajan:bugfix-80173, r=cjgillot Suggest Replacing Comma with Semicolon in Incorrect Repeat Expressions Fixes rust-lang#80173 This PR detects typos in repeat expressions like `["_", 10]` and `vec![String::new(), 10]` and suggests replacing comma with semicolon. Also, improves code in other place by adding doc comments and making use of a helper function to check if a type implements `Clone`. References: 1. For `vec![T; N]`: https://doc.rust-lang.org/std/macro.vec.html 2. For `[T; N]`: https://doc.rust-lang.org/std/primitive.array.html
Fixes #80173
This PR detects typos in repeat expressions like
["_", 10]andvec![String::new(), 10]and suggests replacing comma with semicolon.Also, improves code in other place by adding doc comments and making use of a helper function to check if a type implements
Clone.References:
vec![T; N]: https://doc.rust-lang.org/std/macro.vec.html[T; N]: https://doc.rust-lang.org/std/primitive.array.html